r93520 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93519‎ | r93520 | r93521 >
Date:09:52, 30 July 2011
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
:facepalm: Installer checked for magic_quotes_runtime instead of register_globals
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
——@@ -431,6 +431,7 @@
432432 tries to subsribe to mediawiki-announce.
433433 * (bug 27427) mw.util.getParamValue shouldn't return value from hash even if
434434 param is only present in hash.
 435+* Installer checked for magic_quotes_runtime instead of register_globals.
435436
436437 === API changes in 1.18 ===
437438 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/includes/installer/Installer.php
——@@ -652,7 +652,7 @@
653653 * Environment check for register_globals.
654654 */
655655 protected function envCheckRegisterGlobals() {
656 - if( wfIniGetBool( "magic_quotes_runtime" ) ) {
 656+ if( wfIniGetBool( 'register_globals' ) ) {
657657 $this->showMessage( 'config-register-globals' );
658658 }
659659 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r93521MFT r93520 to 1.18: Installer checked for magic_quotes_runtime instead of reg...maxsem10:17, 30 July 2011
r93522MFT r93520 to 1.17: Installer checked for magic_quotes_runtime instead of reg...maxsem10:20, 30 July 2011
r96559MFT r92422, r93520, r93563, r94107, r94433, r95042, r95332, r95451, r96386...reedy12:49, 8 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   10:20, 30 July 2011

Release notes are misleading (a bit), it still checks for magic_quotes_runtime.

#Comment by MaxSem (talk | contribs)   10:22, 30 July 2011

Where do they say that it doesn't check for magic_quotes_runtime anymore? :P

#Comment by Nikerabbit (talk | contribs)   10:23, 30 July 2011

"The check for register_globals in installer was erroneously checking for magic_quotes_runtime instead."

Status & tagging log