r93366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93365‎ | r93366 | r93367 >
Date:05:57, 28 July 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix broken textSelection test case in IE. All textSelection tests are passing in IE now (at least on my local machine)
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.textSelection.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.textSelection.js
——@@ -163,6 +163,7 @@
164164 range3.moveEnd( 'character', 1 );
165165 if ( range3.text != "\r" && range3.text != "\n" && range3.text != "" ) {
166166 insertText += "\n";
 167+ post += "\n";
167168 }
168169 }
169170

Follow-up revisions

RevisionCommit summaryAuthorDate
r93372Followup r93366: fix Opera bugs in textSelection. All tests pass in Opera now...catrope06:40, 28 July 2011

Comments

#Comment by Krinkle (talk | contribs)   06:03, 28 July 2011

This fixes it for IE8: http://toolserver.org/~krinkle/testswarm/job/257/ (before).

No regressions.

Marking OK.

Status & tagging log