r93273 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93272‎ | r93273 | r93274 >
Date:14:50, 27 July 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r93253. Do not mark DatabaseSqliteTest.php as needing a db.
An existing db is not needed, since it uses a memory one.
Having this in Database group fails in DatabaseSqlite->listTables
since it is working with a MockDatabaseSqlite whose query() return true.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/db/DatabaseSqliteTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/db/DatabaseSqliteTest.php
——@@ -19,7 +19,6 @@
2020
2121 /**
2222 * @group sqlite
23 - * @group Database
2423 */
2524 class DatabaseSqliteTest extends MediaWikiTestCase {
2625 var $db;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93253Mark 2 tests as requiring a DB...since they do :)demon23:39, 26 July 2011

Comments

#Comment by Platonides (talk | contribs)   15:12, 27 July 2011

The return true is what produced (with sqlite db) PHP Warning: Invalid argument supplied for foreach() in /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/db/DatabaseSqlite.php on line 839

#Comment by 😂 (talk | contribs)   19:07, 28 July 2011

Whoops, thanks.

Status & tagging log