r93269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93268‎ | r93269 | r93270 >
Date:14:38, 27 July 2011
Author:robin
Status:reverted (Comments)
Tags:
Comment:
Fix toc margin in modern skin per DieBuche on r90743
Modified paths:
  • /trunk/phase3/skins/modern/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/modern/main.css
——@@ -586,6 +586,13 @@
587587 text-align: left;
588588 }
589589
 590+.mw-content-ltr .toc ul,
 591+.mw-content-rtl .toc ul,
 592+.mw-content-ltr #toc ul,
 593+.mw-content-rtl #toc ul {
 594+ margin: 0 1em;
 595+}
 596+
590597 #toc ul ul,
591598 .toc ul ul {
592599 margin: 0 0 0 2em;

Follow-up revisions

RevisionCommit summaryAuthorDate
r93271merge r93269robin14:39, 27 July 2011
r96614Revert r93271 (merging r93269 from trunk). Trunk rev is fixmed and needs reso...demon20:49, 8 September 2011
r96762Do r93269 in a better way (also fixes some rare cases). Use 'margin/padding' ...robin00:13, 11 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90743Directionality improvements as part of bug 6100 (under $wgBetterDirectionality):...robin23:01, 24 June 2011

Comments

#Comment by Krinkle (talk | contribs)   23:30, 6 September 2011

Right now the style looks like this in modern/main.css: 

#toc ul,
.toc ul {
	list-style-type: none;
	list-style-image: none;
	margin: 0 1em;
	padding: 0;
	text-align: left;
}

.mw-content-ltr .toc ul,
.mw-content-rtl .toc ul,
.mw-content-ltr #toc ul,
.mw-content-rtl #toc ul {
	margin: 0 1em;
}

Why was this fix needed exactly ? The mentioned revision didn't touch modern/main.css, so I' assuming this is a breakage that is being patched here. Please explain the breakage, it likely affects other styles as well.

I do not understand what this fix does though, it looks very wrong.

The margin is both on the left AND right side, directionality should not play any role here.

#Comment by SPQRobin (talk | contribs)   00:14, 11 September 2011

The CSS added in r90743 overrode the CSS present in modern/main.css (the first margin you mention), so I had to add this CSS to override that in return.

I did it differently in r96762 so this css is no longer needed.

Status & tagging log