r93085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93084‎ | r93085 | r93086 >
Date:18:50, 25 July 2011
Author:foxtrott
Status:ok (Comments)
Tags:
Comment:
set elements to display:none explicitly (workaround for css loaded late by RL)
Modified paths:
  • /trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php
@@ -95,7 +95,7 @@
9696 $result .= '<span class="smwtlcomment">' . wfMsgForContent( 'smw_iq_nojs' ) . ' ' . $link->getText( $outputmode, $this->mLinker ) . '</span>'; // note for people without JavaScript
9797
9898 foreach ( $this->m_tlbands as $band ) {
99 - $result .= '<span class="smwtlband">' . htmlspecialchars( $band ) . '</span>';
 99+ $result .= '<span class="smwtlband" style="display:none;">' . htmlspecialchars( $band ) . '</span>';
100100 // just print any "band" given, the JavaScript will figure out what to make of it
101101 }
102102
@@ -212,7 +212,7 @@
213213 if ( $hastime ) {
214214 $result .= Html::rawElement(
215215 'span',
216 - array( 'class' => 'smwtlevent' ),
 216+ array( 'class' => 'smwtlevent', 'style' => 'display:none;' ),
217217 $curmeta . Html::element(
218218 'span',
219219 array( 'class' => 'smwtlcoloricon' ),
@@ -223,7 +223,7 @@
224224
225225 if ( $isEventline ) {
226226 foreach ( $events as $event ) {
227 - $result .= '<span class="smwtlevent"><span class="smwtlstart">' . $event[0] . '</span><span class="smwtlurl">' . $event[1] . '</span><span class="smwtlcoloricon">' . $curcolor . '</span>';
 227+ $result .= '<span class="smwtlevent" style="display:none;" ><span class="smwtlstart">' . $event[0] . '</span><span class="smwtlurl">' . $event[1] . '</span><span class="smwtlcoloricon">' . $curcolor . '</span>';
228228 if ( $curarticle != '' ) $result .= '<span class="smwtlprefix">' . $curarticle . ' </span>';
229229 $result .= $curdata . '</span>';
230230 $positions[$event[2]] = $event[0];
@@ -239,14 +239,14 @@
240240
241241 switch ( $this->m_tlpos ) {
242242 case 'start':
243 - $result .= '<span class="smwtlposition">' . $positions[0] . '</span>';
 243+ $result .= '<span class="smwtlposition" style="display:none;" >' . $positions[0] . '</span>';
244244 break;
245245 case 'end':
246 - $result .= '<span class="smwtlposition">' . $positions[count( $positions ) - 1] . '</span>';
 246+ $result .= '<span class="smwtlposition" style="display:none;" >' . $positions[count( $positions ) - 1] . '</span>';
247247 break;
248248 case 'today': break; // default
249249 case 'middle': default:
250 - $result .= '<span class="smwtlposition">' . $positions[ceil( count( $positions ) / 2 ) - 1] . '</span>';
 250+ $result .= '<span class="smwtlposition" style="display:none;" >' . $positions[ceil( count( $positions ) / 2 ) - 1] . '</span>';
251251 break;
252252 }
253253 }

Comments

#Comment by Jeroen De Dauw (talk | contribs)   18:53, 25 July 2011

Awesome, thnx for fixing :)

Status & tagging log