r93081 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93080‎ | r93081 | r93082 >
Date:18:19, 25 July 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fixed newFromArchiveRow to check for ar_page_id
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
@@ -101,7 +101,7 @@
102102 */
103103 public static function newFromArchiveRow( $row, $overrides = array() ) {
104104 $attribs = $overrides + array(
105 - 'page' => isset( $row->page_id ) ? $row->page_id : null,
 105+ 'page' => isset( $row->ar_page_id ) ? $row->ar_page_id : null,
106106 'id' => isset( $row->ar_rev_id ) ? $row->ar_rev_id : null,
107107 'comment' => $row->ar_comment,
108108 'user' => $row->ar_user,

Follow-up revisions

RevisionCommit summaryAuthorDate
r95516MFT r93081 - r95515awjrichards20:47, 25 August 2011

Comments

#Comment by Hashar (talk | contribs)   01:41, 28 July 2011

does not trigger any bug since we always override page_id :) Removing 1.17 & 1.18 keywords.

Status & tagging log