r93062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93061‎ | r93062 | r93063 >
Date:16:51, 25 July 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
r92054: Some IE fixes
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -181,12 +181,13 @@
182182 /**
183183 * Categories
184184 */
185 -#catlinks ul, #catlinks li {
 185+#catlinks ul {
186186 display:inline;
187187 margin: 0px;
188188 list-style:none;
189189 list-style-type:none;
190190 list-style-image:none;
 191+ vertical-align: middle !ie;
191192 }
192193
193194 #catlinks li {
——@@ -195,13 +196,14 @@
196197 padding: 0 .7em;
197198 border-left: 1px solid #AAA;
198199 margin: 0.3em 0;
 200+ zoom: 1;
 201+ display:inline !ie;
199202 }
200203
201204 #catlinks li:first-child {
202205 padding-left: .4em;
203206 border-left: none;
204207 }
205 -
206208 /**
207209 * Hidden categories
208210 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r964701.17wmf1: MFT r92962, r93062, r93093, r93385, r93468, r93473, r94350, r94502,...catrope19:07, 7 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92054Render category links as an HTML list. Bug 12261. Based on patch by Thana & B...diebuche10:41, 13 July 2011

Comments

#Comment by Krinkle (talk | contribs)   23:10, 25 July 2011

A more descriptive commit message would be helpful. What "some IE fixes" ? What was broken ?

#Comment by DieBuche (talk | contribs)   07:16, 26 July 2011

In IE6 the "Category:" label was not correctly aligned (vertica-align). In IE6+7 there's no inline-block support w/o workarounds

#Comment by Krinkle (talk | contribs)   19:48, 24 August 2011

Okay. Makes sense. Looks good.

#Comment by Krinkle (talk | contribs)   19:48, 24 August 2011

Why was the selector changed from #catlinks ul, #catlinks li { to #catlinks ul { ?

Status & tagging log