r93023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93022‎ | r93023 | r93024 >
Date:22:18, 24 July 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
let sysops have the right to edit widgets by default; really doesn't make sense & is annoying to not have this
Modified paths:
  • /trunk/extensions/Widgets/Widgets.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Widgets/Widgets.php
@@ -42,6 +42,7 @@
4343
4444 // Define new right
4545 $wgAvailableRights[] = 'editwidgets';
 46+$wgGroupPermissions['sysop']['editwidgets'] = true;
4647
4748 // Set this to true to use FlaggedRevs extension's stable version for widget security
4849 $wgWidgetsUseFlaggedRevs = false;
@@ -93,8 +94,7 @@
9495 function widgetNamespacesInit() {
9596 global $wgGroupPermissions, $wgNamespaceProtection, $wgWidgetsUseFlaggedRevs;
9697
97 - if (!$wgWidgetsUseFlaggedRevs)
98 - {
 98+ if ( !$wgWidgetsUseFlaggedRevs ) {
9999 // Assign editing to widgeteditor group only (widgets can be dangerous so we do it here, not in LocalSettings)
100100 $wgGroupPermissions['*']['editwidgets'] = false;
101101 $wgGroupPermissions['widgeteditor']['editwidgets'] = true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r93030fu r93023jeroendedauw23:36, 24 July 2011

Status & tagging log