r92964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92963‎ | r92964 | r92965 >
Date:20:56, 23 July 2011
Author:jeroendedauw
Status:ok (Comments)
Tags:lamecommitsummary 
Comment:
fu r92933 - fix breakage
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -359,7 +359,8 @@
360360 var pad = function( a, b, c ) {
361361 return [a < 10 ? '0' + a : a, b < 10 ? '0' + b : b, c < 10 ? '0' + c : c].join( '' );
362362 },
363 - d = new Date().setTime( timestamp * 1000 );
 363+ d = new Date();
 364+ d.setTime( timestamp * 1000 );
364365 return [
365366 pad( d.getUTCFullYear(), d.getUTCMonth() + 1, d.getUTCDate() ), 'T',
366367 pad( d.getUTCHours(), d.getUTCMinutes(), d.getUTCSeconds() ), 'Z'

Follow-up revisions

RevisionCommit summaryAuthorDate
r93012More mediawiki.js cleanup...krinkle20:22, 24 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92933Minor mw.loader fixes...krinkle09:09, 23 July 2011

Comments

#Comment by Nikerabbit (talk | contribs)   21:17, 23 July 2011

Can you explain what is going on here? I don't understand :(

#Comment by Jeroen De Dauw (talk | contribs)   21:32, 23 July 2011

That JS does not what is intended here. Putting it on 2 lines does. Putting brackets around new Date would also work I guess.

Status & tagging log