r92934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92933‎ | r92934 | r92935 >
Date:09:19, 23 July 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix typo in r92933 that resulted in global variable leakage
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -147,7 +147,7 @@
148148 // Return <key> if key does not exist
149149 return '<' + this.key + '>';
150150 }
151 - var text = this.map.get( this.key );
 151+ var text = this.map.get( this.key ),
152152 parameters = this.parameters;
153153
154154 text = text.replace( /\$(\d+)/g, function( string, match ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92933Minor mw.loader fixes...krinkle09:09, 23 July 2011

Comments

#Comment by Krinkle (talk | contribs)   18:01, 23 July 2011

Thx

Status & tagging log