r92913 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92912‎ | r92913 | r92914 >
Date:22:55, 22 July 2011
Author:catrope
Status:ok
Tags:
Comment:
RL2: Add ampersand to indicate pass-by-reference in unitTestsList hook function. It seems to work without but I don't really understand why
Modified paths:
  • /branches/RL2/extensions/Gadgets/GadgetHooks.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/GadgetHooks.php
@@ -177,7 +177,7 @@
178178 * UnitTestsList hook handler
179179 * @param $files Array: List of extension test files
180180 */
181 - public static function unitTestsList( $files ) {
 181+ public static function unitTestsList( &$files ) {
182182 $files[] = dirname( __FILE__ ) . '/tests/GadgetsTest.php';
183183 return true;
184184 }

Status & tagging log