r92914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92913‎ | r92914 | r92915 >
Date:22:58, 22 July 2011
Author:brion
Status:ok
Tags:
Comment:
CodeReview extension: fix for authentication, which was not being used in PECL svn mode (oops!)

This caused breakage for one user who found us on IRC, where the CLI scripts seemed to work (perhaps due to using the SVN command-line bits, which did handle auth) and the web scripts didn't.
Now works for both! For proxy users, that's your proxy's problem. ;)
Modified paths:
  • /trunk/extensions/CodeReview/backend/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/Subversion.php
——@@ -63,6 +63,14 @@
6464 */
6565 class SubversionPecl extends SubversionAdaptor {
6666
 67+ function __construct( $repoPath ) {
 68+ parent::__construct( $repoPath );
 69+ global $wgSubversionUser, $wgSubversionPassword;
 70+ if ( $wgSubversionUser ) {
 71+ svn_auth_set_parameter( SVN_AUTH_PARAM_DEFAULT_USERNAME, $wgSubversionUser );
 72+ svn_auth_set_parameter( SVN_AUTH_PARAM_DEFAULT_PASSWORD, $wgSubversionPassword );
 73+ }
 74+ }
6775 /**
6876 * Just return true for now. svn_info() is too slow to be useful...
6977 *

Status & tagging log