r92818 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92817‎ | r92818 | r92819 >
Date:22:36, 21 July 2011
Author:werdna
Status:deferred
Tags:
Comment:
MoodBar: Fix up loading/error/success screens
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css
@@ -141,3 +141,11 @@
142142 .mw-moodBar-formInputs {
143143 padding-left: 2em;
144144 }
 145+
 146+.mw-moodBar-loading {
 147+ background-image: url(images/ajax-spinner.gif);
 148+ background-position: left center;
 149+ background-repeat: no-repeat;
 150+ padding-left: 70px;
 151+ height: 70px;
 152+}
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -40,11 +40,11 @@
4141 <span class="mw-moodBar-typeTitle"><html:msg key="moodbar-type-$1-title" /></span>\
4242 </div>',
4343 loading: '\
44 - <div><img src="' + mw.config.get( 'wgExtensionAssetsPath' ) + '/MoodBar/modules/ext.moodBar/images/ajax-spinner.gif" />Sharing...</div>',
 44+ <div class="mw-moodBar-loading"><html:msg key="mw-moodbar-loading-title"/></div>',
4545 success: '\
46 - <div>Thanks!</div>',
 46+ <div><html:msg key="mw-moodbar-success-title" /></div>',
4747 error: '\
48 - <div>Oops!</div>'
 48+ <div><html:msg key="mw-moodbar-error-title" /></div>'
4949 },
5050
5151 event: {

Follow-up revisions

RevisionCommit summaryAuthorDate
r92819Fix r92818werdna22:39, 21 July 2011

Status & tagging log