r92807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92806‎ | r92807 | r92808 >
Date:22:10, 21 July 2011
Author:raindrift
Status:resolved (Comments)
Tags:
Comment:
removed cruft, followup to r92805
Modified paths:
  • /trunk/extensions/TitleBlacklist/api/ApiQueryTitleBlacklist.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TitleBlacklist/api/ApiQueryTitleBlacklist.php
——@@ -102,9 +102,7 @@
103103 }
104104
105105 public function getPossibleErrors() {
106 -
107 - //return array_merge( parent::getPossibleErrors(), array(
108 - //) );
 106+
109107 }
110108
111109 protected function getExamples() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r92921Fixed unit test...raindrift00:23, 23 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92805Added an API to TitleBlackList to make it possible to check the blacklist in ...raindrift22:08, 21 July 2011

Comments

#Comment by Reedy (talk | contribs)   12:47, 22 July 2011

If you're not explicitly implementing any errors yourself, you might aswell just comment out/remove the whole method in your implementation

#Comment by Raindrift (talk | contribs)   00:23, 23 July 2011

Good point.

Status & tagging log