r92589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92588‎ | r92589 | r92590 >
Date:21:41, 19 July 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Since r92364 UserTest.php needs a database
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/UserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/UserTest.php
——@@ -3,6 +3,9 @@
44 define( 'NS_UNITTEST', 5600 );
55 define( 'NS_UNITTEST_TALK', 5601 );
66
 7+/**
 8+ * @group Database
 9+ */
710 class UserTest extends MediaWikiTestCase {
811 protected $savedGroupPermissions, $savedRevokedPermissions;
912 protected $user;
——@@ -161,4 +164,4 @@
162165 ),
163166 );
164167 }
165 -}
\ No newline at end of file
 168+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r105851Reverted r92364 (per-namespace permissions)....tstarling06:03, 12 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92364First steps for bug 14801: add backend support for per-namespace permissions ...btongminh16:09, 16 July 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:16, 20 July 2011

I've noticed that your editor adds a newline at the end of the file. I think that is a good thing, but should we run a general cleanup?

#Comment by Platonides (talk | contribs)   19:52, 20 July 2011

A quick check shows that 1274 end in a newline and 17 do not. It's generally not worth an EOF vendetta, but since there are so few, why not?

Status & tagging log