| Index: trunk/phase3/tests/phpunit/includes/BlockTest.php |
| — | — | @@ -83,25 +83,6 @@ |
| 84 | 84 | } |
| 85 | 85 | |
| 86 | 86 | /** |
| 87 | | - * This is the method previously used to load block info in CheckUser etc |
| 88 | | - * passing an empty value (empty string, null, etc) as the ip parameter bypasses IP lookup checks. |
| 89 | | - * |
| 90 | | - * This stopped working with r84475 and friends: regression being fixed for bug 29116. |
| 91 | | - * |
| 92 | | - * @dataProvider dataBug29116 |
| 93 | | - */ |
| 94 | | - function testBug29116LoadWithEmptyIp( $vagueTarget ) { |
| 95 | | - $uid = User::idFromName( 'UTBlockee' ); |
| 96 | | - $this->assertTrue( ($uid > 0), 'Must be able to look up the target user during tests' ); |
| 97 | | - |
| 98 | | - $block = new Block(); |
| 99 | | - $ok = $block->load( $vagueTarget, $uid ); |
| 100 | | - $this->assertTrue( $ok, "Block->load() with empty IP and user ID '$uid' should return a block" ); |
| 101 | | - |
| 102 | | - $this->assertTrue( $this->block->equals( $block ), "Block->load() returns the same block as the one that was made when given empty ip param " . var_export( $vagueTarget, true ) ); |
| 103 | | - } |
| 104 | | - |
| 105 | | - /** |
| 106 | 87 | * CheckUser since being changed to use Block::newFromTarget started failing |
| 107 | 88 | * because the new function didn't accept empty strings like Block::load() |
| 108 | 89 | * had. Regression bug 29116. |