r92484 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92483‎ | r92484 | r92485 >
Date:22:01, 18 July 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
It seems people don't either pay attention to code comments, or those comments lie

r92461
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -282,7 +282,7 @@
283283 * Load user table data, given mId has already been set.
284284 * @return Bool false if the ID does not exist, true otherwise
285285 */
286 - private function loadFromId() {
 286+ public function loadFromId() {
287287 global $wgMemc;
288288 if ( $this->mId == 0 ) {
289289 $this->loadDefaults();
@@ -859,7 +859,7 @@
860860 *
861861 * @param $name string
862862 */
863 - private function loadDefaults( $name = false ) {
 863+ public function loadDefaults( $name = false ) {
864864 wfProfileIn( __METHOD__ );
865865
866866 $this->mId = 0;
@@ -1016,7 +1016,7 @@
10171017 *
10181018 * @return Bool True if the user exists, false if the user is anonymous
10191019 */
1020 - private function loadFromDatabase() {
 1020+ public function loadFromDatabase() {
10211021 # Paranoia
10221022 $this->mId = intval( $this->mId );
10231023
@@ -2758,7 +2758,7 @@
27592759 * Clear the user's cookies and session, and reset the instance cache.
27602760 * @see logout()
27612761 */
2762 - private function doLogout() {
 2762+ public function doLogout() {
27632763 $this->clearInstanceCache( 'defaults' );
27642764
27652765 $this->getRequest()->setSessionData( 'wsUserID', 0 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92505MFT r92477, r92480, r92481, r92482, r92484, r9485, r92486...reedy23:14, 18 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92461Set explicit public modifier...reedy19:56, 18 July 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   17:21, 21 July 2011

What about decodeOptions?

Status & tagging log