r92436 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92435‎ | r92436 | r92437 >
Date:15:37, 18 July 2011
Author:ankitgarg833
Status:resolved (Comments)
Tags:
Comment:
modifying few names to match standards
Modified paths:
  • /trunk/extensions/PageSchemas/PageSchemas.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PageSchemas/PageSchemas.i18n.php
@@ -15,12 +15,12 @@
1616 $messages = array();
1717
1818 $messages['en'] = array(
19 - 'pageschemas-desc' => 'Supports templates defining their data structure via XML markup',
 19+ 'pageschemas-desc' => 'XML schemas for defining the structure of wiki pages',
2020 'pageschemas-header' => 'The XML definition for this template is:',
2121 'ps-property-isproperty' => 'This is a property of type $1.',
2222 'ps-property-allowedvals' => 'The allowed {{PLURAL:$1|value for this property is|values for this property are}}:',
23 - 'ps-generate-pages' => 'Generate Pages',
24 - 'ps-generate-pages-desc' => 'Generate the following pages, based on this category\'s schema:',
 23+ 'generatepages' => 'Generate pages',
 24+ 'generatepages-desc' => 'Generate the following pages, based on this category\'s schema:',
2525 );
2626
2727 /** Message documentation (Message documentation)

Follow-up revisions

RevisionCommit summaryAuthorDate
r92719Resolve fixmes on r92436, r92439 by readding prefix to msg namesdemon00:44, 21 July 2011

Comments

#Comment by Raymond (talk | contribs)   15:46, 18 July 2011

To what kind of standard do you refer?

Standard is to prefix message keys with the extension name, at least with an abbreviation of the extension name, to avoid conflicts with other extensions. Now your message keys could conflict with an hypothetical extension called "Generatepages"

Status & tagging log