r92381 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r92380‎ \| r92381 \| r92382 >
Date:	20:50, 16 July 2011
Author:	jeroendedauw
Status:	deferred (Comments)
Tags:
Comment:	rev r92379, this right is not set by default
Modified paths:	/trunk/extensions/SemanticMediaWiki/specials/SMWAdmin/SMW_SpecialSMWAdmin.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/SMWAdmin/SMW_SpecialSMWAdmin.php
—	—	@@ -22,11 +22,12 @@
23	23	* @ingroup SpecialPage
24	24	*/
25	25	class SMWAdmin extends SpecialPage {
	26	+
26	27	/**
27	28	* Constructor
28	29	*/
29	30	public function __construct() {
30		~~- parent::__construct( 'SMWAdmin', 'siteadmin' );~~
	31	+ parent::__construct( 'SMWAdmin', 'delete' );
31	32	smwfLoadExtensionMessages( 'SemanticMediaWiki' );
32	33	}
33	34

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r92379	required siteadmin right instead of delete right for special smwadmin	jeroendedauw	20:26, 16 July 2011

Comments

#Comment by Nikerabbit (talk | contribs) 08:18, 17 July 2011

I don't like using unrelated rights, especially since this cannot be overridden.

#Comment by Jeroen De Dauw (talk | contribs) 14:14, 17 July 2011

Yeah, me neither, which I why I originally changed this. Not sure what the best approach to "fixing" this is though. Can introduce a new right such as smwadmin, but I think it'd be nicer to have a general siteadmin right, which there is, but is not assigned by default.