r92245 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92244‎ | r92245 | r92246 >
Date:15:06, 15 July 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
r92054 : Fix wordwrap by using inline-block. This has the nice sideeffect of fixing an Opera background image bug as well. Remove categories from print, they're not especially useful on paper. (Also give footer some space)
Modified paths:
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/commonPrint.css
——@@ -127,7 +127,7 @@
128128 li#disclaimer,
129129 li#privacy,
130130 #footer-places,
131 -#mw-hidden-catlinks {
 131+#catlinks {
132132 /* Hides all the elements irrelevant for printing */
133133 display: none;
134134 }
——@@ -146,7 +146,8 @@
147147 #footer {
148148 background : white;
149149 color : black;
150 - border-top: 1px solid black;
 150+ margin-top: 1em;
 151+ border-top: 1px solid #AAA;
151152 direction: ltr;
152153 }
153154
Index: trunk/phase3/skins/common/shared.css
——@@ -190,8 +190,11 @@
191191 }
192192
193193 #catlinks li {
 194+ display:inline-block;
 195+ line-height: 1.35em;
194196 padding: 0 .7em;
195197 border-left: 1px solid #AAA;
 198+ margin: 0.3em 0;
196199 }
197200
198201 #catlinks li:first-child {

Follow-up revisions

RevisionCommit summaryAuthorDate
r95436Partially revert r92245 per r92245 CR.krinkle19:56, 24 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92054Render category links as an HTML list. Bug 12261. Based on patch by Thana & B...diebuche10:41, 13 July 2011

Comments

#Comment by Krinkle (talk | contribs)   19:58, 24 August 2011

Reverted the commonPrint.css change in r95436.

It was discussed a little bit in r92054 CR, but I'm not (yet) convinced they are irrelevant for print. Please open a ticket if you think they should be hidden (including motivation).

Marking OK.

Status & tagging log