r92233 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92232‎ | r92233 | r92234 >
Date:09:23, 15 July 2011
Author:ialex
Status:deferred
Tags:
Comment:
* OutputPage::addWikiMsgArray() -> OutputPage::addWikiMsg()
* Removed usage of $wgMessageCache, this variable no longer exists
* Quick whitespaces fixes
Modified paths:
  • /trunk/extensions/ExtensionManagement/specials/SpecialExtensionManagement.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionManagement/specials/SpecialExtensionManagement.php
@@ -19,28 +19,27 @@
2020 'https://svn.wikimedia.org/viewvc/mediawiki' => 'http://svn.wikimedia.org/viewvc/mediawiki',
2121 );
2222
23 - function __construct() {
24 - parent::__construct( 'ExtensionManagement' );
25 - }
 23+ function __construct() {
 24+ parent::__construct( 'ExtensionManagement' );
 25+ }
2626
27 -
28 - function execute( $par ) {
29 - global $wgOut, $wgMessageCache, $wgContLang;
30 - $wgMessageCache->loadAllMessages();
3127
 28+ function execute( $par ) {
 29+ global $wgOut, $wgContLang;
 30+
3231 $this->setHeaders();
3332 $this->outputHeader();
3433
3534 $wgOut->addHTML( Xml::openElement( 'div',
3635 array( 'dir' => $wgContLang->getDir() ) ) );
37 - $wgOut->addWikiMsgArray( 'extensionmanagement-page-explanation', '' );
 36+ $wgOut->addWikiMsg( 'extensionmanagement-page-explanation', '' );
3837
3938 $text =
4039 $this->displayExtensions();
4140
4241 $wgOut->addWikiText( $text );
4342 $wgOut->addHTML( '</div>' );
44 - }
 43+ }
4544
4645
4746 function displayExtensions() {

Status & tagging log