r92232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92231‎ | r92232 | r92233 >
Date:08:52, 15 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Use OutputPage::addWikiMsg() instead of OutputPage::addWikiMsgArray()
Modified paths:
  • /trunk/extensions/Deployment/specials/SpecialExtensions.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialInstall.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialUpdate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/specials/SpecialExtensions.php
@@ -72,7 +72,7 @@
7373 }
7474 else {
7575 // TODO: fix url
76 - $wgOut->addWikiMsgArray( 'extension-page-explanation', '' );
 76+ $wgOut->addWikiMsg( 'extension-page-explanation' );
7777 }
7878
7979 $wgOut->addHTML(
@@ -185,7 +185,7 @@
186186 global $wgOut, $wgExtensionCredits;
187187
188188 if ( !array_key_exists( $this->typeFilter, $wgExtensionCredits ) && $this->typeFilter != 'all' ) {
189 - $wgOut->addWikiMsgArray( 'extension-invalid-category', $this->typeFilter );
 189+ $wgOut->addWikiMsg( 'extension-invalid-category', $this->typeFilter );
190190 $this->typeFilter = 'all';
191191 }
192192
@@ -202,10 +202,10 @@
203203
204204 if ( count( $extensions ) == 0 ) {
205205 if ( $this->typeFilter == 'all' ) {
206 - $wgOut->addWikiMsgArray( 'extension-none-installed', 'Special:Install' );
 206+ $wgOut->addWikiMsg( 'extension-none-installed', 'Special:Install' );
207207 }
208208 else {
209 - $wgOut->addWikiMsgArray( 'extension-empty-category', $this->typeFilter );
 209+ $wgOut->addWikiMsg( 'extension-empty-category', $this->typeFilter );
210210 }
211211 }
212212 else {
@@ -315,4 +315,4 @@
316316 return $html;
317317 }
318318
319 -}
\ No newline at end of file
 319+}
Index: trunk/extensions/Deployment/specials/SpecialUpdate.php
@@ -94,7 +94,7 @@
9595 else {
9696 $wgOut->addHTML( '<h3>' . wfMsg( 'mediawiki-update-available' ) . '</h3>' );
9797 // TODO: link
98 - $wgOut->addWikiMsgArray( 'mediawiki-update-available-long', array( $status, '' ) );
 98+ $wgOut->addWikiMsg( 'mediawiki-update-available-long', $status, '' );
9999 }
100100 }
101101
@@ -185,4 +185,4 @@
186186 );
187187 }
188188
189 -}
\ No newline at end of file
 189+}
Index: trunk/extensions/Deployment/specials/SpecialInstall.php
@@ -70,7 +70,7 @@
7171 protected function showFullSearchOptions() {
7272 global $wgOut, $wgUser, $wgRepositoryLocation;
7373
74 - $wgOut->addWikiMsgArray( 'extensions-description', $wgRepositoryLocation );
 74+ $wgOut->addWikiMsg( 'extensions-description', $wgRepositoryLocation );
7575
7676 $searchHtml = Html::element( 'h2', array(), wfMsg( 'search-extensions' ) );
7777 $searchHtml .= wfMsg( 'search-extensions-long' );
@@ -256,4 +256,4 @@
257257 return $html . '</tr>';
258258 }
259259
260 -}
\ No newline at end of file
 260+}

Status & tagging log