r92131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92130‎ | r92131 | r92132 >
Date:01:13, 14 July 2011
Author:robin
Status:ok
Tags:
Comment:
* Fix r80248: login language links included a newline in the URL (%0D) so the links didn't work
* (Also make linkKnown() to use Linker)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -1162,7 +1162,7 @@
11631163 $lang = trim( $lang, '* ' );
11641164 $parts = explode( '|', $lang );
11651165 if ( count( $parts ) >= 2 ) {
1166 - $links[] = $this->makeLanguageSelectorLink( $parts[0], $parts[1] );
 1166+ $links[] = $this->makeLanguageSelectorLink( $parts[0], trim( $parts[1] ) );
11671167 }
11681168 }
11691169 return count( $links ) > 0 ? wfMsgHtml( 'loginlanguagelabel', $wgLang->pipeList( $links ) ) : '';
@@ -1187,8 +1187,7 @@
11881188 if( $this->mReturnTo ) {
11891189 $attr['returnto'] = $this->mReturnTo;
11901190 }
1191 - $skin = $this->getSkin();
1192 - return $skin->linkKnown(
 1191+ return Linker::linkKnown(
11931192 $self,
11941193 htmlspecialchars( $text ),
11951194 array(),

Follow-up revisions

RevisionCommit summaryAuthorDate
r92137merge r92131 as this bug is also present in 1.18robin02:01, 14 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80248Implement Message::isBlank and Message::isDisabled....dantman10:51, 14 January 2011

Status & tagging log