r92124 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92123‎ | r92124 | r92125 >
Date:23:26, 13 July 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 26360) $wgSessionHandler was overriding system settings unconditionally. Regression I introduced a little over 2 years ago with r49370.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -164,6 +164,7 @@
165165 * (bug 20781) Move 'mainpagetext' messages to installer's .i18n file.
166166 * (bug 29737) "MediaWiki:Qbsettings-directionality" should refer to script,
167167 not language.
 168+* (bug 26360) $wgSessionHandler was overriding system settings unconditionally.
168169
169170 === API changes in 1.19 ===
170171 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1533,7 +1533,7 @@
15341534 * 'session_mysql.' Setting to null skips setting this entirely (which might be
15351535 * useful if you're doing cross-application sessions, see bug 11381)
15361536 */
1537 -$wgSessionHandler = 'files';
 1537+$wgSessionHandler = null;
15381538
15391539 /** If enabled, will send MemCached debugging information to $wgDebugLogFile */
15401540 $wgMemCachedDebug = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49370(bugs 11381, 11613) Session.save_handler issues:...demon14:53, 10 April 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   17:58, 14 July 2011

r49370 preserved the previous behavior by default (force the setting to 'files' unless we're using $wgSessionsInMemcached) which had been deliberately selected several years ago, so I don't see how it was a regression.

(We chose to force it to 'files' because there were complaints of some servers where the setting got left at something utterly bizarre by some other app. This may not be a current issue.)

#Comment by 😂 (talk | contribs)   18:00, 14 July 2011

Right now if you don't use $wgSessionsInMemcached, but you have session_handler set, we're overriding your current session_handler with 'files.' This is not correct for setups that have a perfectly fine session_handler setup already.

#Comment by Brion VIBBER (talk | contribs)   17:58, 16 July 2011

Yeah, just saying that's the exact same thing we did before r49370, so r49370 didn't cause it. :)

Status & tagging log