r92104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92103‎ | r92104 | r92105 >
Date:22:03, 13 July 2011
Author:catrope
Status:ok
Tags:
Comment:
ArticleFeedback: Add disclaimer message per Howie
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -62,7 +62,8 @@
6363 'articlefeedback-pitch-edit-accept',
6464 'articlefeedback-survey-title',
6565 'articlefeedback-survey-message-success',
66 - 'articlefeedback-survey-message-error',
 66+ 'articlefeedback-survey-message-error',
 67+ 'articlefeedback-survey-disclaimer'
6768 ),
6869 'dependencies' => array(
6970 'jquery.ui.dialog',
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -114,6 +114,10 @@
115115 .insertAfter( $input );
116116 $input.remove();
117117 $form.find( '#prefswitch-survey-origin' ).text( mw.config.get( 'wgTitle' ) );
 118+
 119+ // Insert disclaimer message
 120+ $button.before( $( '<div>' ).addClass( 'articleFeedback-survey-disclaimer' ).text( mw.msg( 'articlefeedback-survey-disclaimer' ) ) );
 121+
118122 // Take dialog out of loading state
119123 $dialog.removeClass( 'loading' );
120124 } );
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.css
@@ -4,4 +4,9 @@
55 #articleFeedback-dialog {
66 padding: 2em;
77 padding-top: 1em;
8 -}
\ No newline at end of file
 8+}
 9+
 10+.articleFeedback-survey-disclaimer {
 11+ font-weight: normal; /* Override bold */
 12+ font-style: italic;
 13+}
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -26,6 +26,7 @@
2727 'articlefeedback-survey-submit' => 'Submit',
2828 'articlefeedback-survey-title' => 'Please answer a few questions',
2929 'articlefeedback-survey-thanks' => 'Thanks for filling out the survey.',
 30+ 'articlefeedback-survey-disclaimer' => 'To help improve this feature, your feedback may be shared anonymously with the Wikipedia community.',
3031 /* ext.articleFeedback and jquery.articleFeedback */
3132 'articlefeedback-error' => 'An error has occured. Please try again later.',
3233 'articlefeedback-form-switch-label' => 'Rate this page',
@@ -167,6 +168,7 @@
168169 {{Identical|Submit}}',
169170 'articlefeedback-survey-title' => 'This text appears in the title bar of the survey dialog.',
170171 'articlefeedback-survey-thanks' => 'This text appears when the user has successfully submitted the survey.',
 172+ 'articlefeedback-survey-disclaimer' => 'This text appears on the survey form below the comment field and above the submit button.',
171173 'articlefeedback-form-panel-explanation-link' => 'Do not translate "Project:". Also translate the "ArticleFeedback" special page name at [[Special:AdvancedTranslate]].',
172174 'articlefeedback-form-panel-helpimprove-email-placeholder' => '{{Optional}}',
173175 'articlefeedback-form-panel-helpimprove-privacy' => '{{Identical|Privacy}}',

Follow-up revisions

RevisionCommit summaryAuthorDate
r925611.17wmf1: MFT r92104catrope19:53, 19 July 2011

Status & tagging log