r92011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92010‎ | r92011 | r92012 >
Date:21:28, 12 July 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Do r91966 in a different way, per Brion: use unicode-bidi:embed; instead of white-space:nowrap;
Modified paths:
  • /trunk/phase3/includes/actions/CreditsAction.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -777,4 +777,5 @@
778778 position: relative;
779779 }
780780
781 -.mw-link-nowrap { white-space: nowrap; }
\ No newline at end of file
 781+/* bug 12205 */
 782+#mw-credits a { unicode-bidi: embed; }
\ No newline at end of file
Index: trunk/phase3/includes/actions/CreditsAction.php
@@ -53,7 +53,7 @@
5454
5555 wfProfileOut( __METHOD__ );
5656
57 - return $s;
 57+ return Html::rawElement( 'div', array( 'id' => 'mw-credits' ), $s );
5858 }
5959
6060 /**
@@ -196,10 +196,7 @@
197197 ? SpecialPage::getTitleFor( 'Contributions', $user->getName() )
198198 : $user->getUserPage();
199199
200 - return Html::rawElement( 'span',
201 - array( 'class' => 'mw-link-nowrap' ),
202 - Linker::link( $page, htmlspecialchars( $real ? $real : $user->getName() ) )
203 - );
 200+ return Linker::link( $page, htmlspecialchars( $real ? $real : $user->getName() ) );
204201 }
205202
206203 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91966(bug 12205) Bidirectional names in action=credits are split and displayed inc...robin14:58, 12 July 2011

Comments

#Comment by Amire80 (talk | contribs)   13:44, 20 July 2011

Status & tagging log