r91804 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91803‎ | r91804 | r91805 >
Date:19:38, 9 July 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Added Request::setLang() and RequestContext::setSkin(); the latter will clone the object and set the context on it.
Modified paths:
  • /trunk/phase3/includes/RequestContext.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RequestContext.php
@@ -126,6 +126,15 @@
127127 }
128128
129129 /**
 130+ * Set the Language object
 131+ *
 132+ * @param $l Language
 133+ */
 134+ public function setLang( Language $l ) {
 135+ $this->lang = $l;
 136+ }
 137+
 138+ /**
130139 * Get the Language object
131140 *
132141 * @return Language
@@ -159,6 +168,16 @@
160169 }
161170
162171 /**
 172+ * Set the Skin object
 173+ *
 174+ * @param $s Skin
 175+ */
 176+ public function setSkin( Skin $s ) {
 177+ $this->skin = clone $s;
 178+ $this->skin->setContext( $this );
 179+ }
 180+
 181+ /**
163182 * Get the Skin object
164183 *
165184 * @return Skin

Comments

#Comment by Nikerabbit (talk | contribs)   20:44, 9 July 2011

Bug 29524 should be taken care of asap.

Status & tagging log