r91786 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91785‎ | r91786 | r91787 >
Date:12:54, 9 July 2011
Author:robin
Status:reverted (Comments)
Tags:
Comment:
Follow-up r91770: only translate when possible
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
——@@ -3018,7 +3018,7 @@
30193019 }
30203020 }
30213021 // If no duration is given, but a timestamp, display that
3022 - return $this->timeanddate( $str );
 3022+ return ( strtotime( $str ) ? $this->timeanddate( strtotime( $str ) ) : $str );
30233023 }
30243024
30253025 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r99154* (bug 31352) Fix regression causing relative block times in log display to r...brion22:20, 6 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91770Translate the block expiry date...robin23:36, 8 July 2011

Comments

#Comment by Nikerabbit (talk | contribs)   14:03, 9 July 2011

Now it converts relative expressions to absolute ones?

#Comment by SPQRobin (talk | contribs)   16:41, 9 July 2011

Apparently it does convert it to absolute ones when there is no translation in ipboptions. This block log system really sucks. I'm trying to figure out a good way. Perhaps it's better to first propose it as a patch. If it works, it would also solve the fact that relative time is only translated if there is an equivalent in ipboptions.

#Comment by Nikerabbit (talk | contribs)   17:07, 9 July 2011

Like I said elsewhere, we should limit the input to predefined ones we can translate. See for example http://translatewiki.net/wiki/LocalTime .

#Comment by Brion VIBBER (talk | contribs)   22:23, 6 October 2011

Reverted in r99155.

#Comment by Brion VIBBER (talk | contribs)   22:23, 6 October 2011

r99154. blaaaah

Status & tagging log