r91762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91761‎ | r91762 | r91763 >
Date:21:32, 8 July 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Undo browser defaults (underline/strike) for the <del> and <ins> DairikiDiff inserts. Fixes bug 29779
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -146,6 +146,8 @@
147147 left/right according to the directionality of your interface language.
148148 * (bug 19514) Unordered list list-style-image should be IE6-compatible (8-bit)
149149 * (bug 27410) The tag filter on a history page is now within a <label> element
 150+* (bug 29779) DairikiDiff/WikiDiff <ins> and <del> should undo browser default
 151+ styling (strike/underline).
150152
151153 === API changes in 1.19 ===
152154 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
——@@ -31,6 +31,7 @@
3232 font-weight: bold;
3333 white-space: -moz-pre-wrap;
3434 white-space: pre-wrap;
 35+ text-decoration: none;
3536 }
3637
3738 table.diff {

Follow-up revisions

RevisionCommit summaryAuthorDate
r112750[mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it ...krinkle01:07, 1 March 2012

Comments

#Comment by Hashar (talk | contribs)   21:42, 8 July 2011

Does it need a backport to 1.18/1.17? The bug report was mentioning 1.17 (I have updated it to 1.19-svn since).

#Comment by Krinkle (talk | contribs)   21:45, 8 July 2011

Yes. Sorry forgot to tag.

note there is no need to merge to 1.17wmf1 as WMF uses a different diff engine.

#Comment by Reedy (talk | contribs)   17:35, 15 July 2011

Any idea where this is supposed to go in 1.17? The mediawiki.action.history.diff.css file doesn't exist, and I can't see anywhere obvious it should live

#Comment by Krinkle (talk | contribs)   20:17, 15 July 2011

In 1.17 this would go in /skins/common/diff.css

However.. as ^demon pointed out on IRC apparently this property is already set in REL1_17: http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_17/phase3/skins/common/diff.css?revision=87170&view=markup&pathrev=87170#l29

So the question is, who removed it between 1.17 and 1.18 ?

#Comment by Krinkle (talk | contribs)   20:17, 15 July 2011

Untagging 1.17 per the above

Status & tagging log