r91749 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r91748‎ \| r91749 \| r91750 >
Date:	18:58, 8 July 2011
Author:	diebuche
Status:	deferred (Comments)
Tags:	diebuche, todo
Comment:	r86603 : Updating module name of mediawiki.legacy.edit in SemanticForms Extension
Modified paths:	/trunk/extensions/SemanticForms/specials/SF_UploadWindow2.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_UploadWindow2.php
—	—	@@ -956,7 +956,7 @@
957	957
958	958	if ( method_exists( $wgOut, 'addModules' ) ) {
959	959	$head_scripts = '';
960		~~- $wgOut->addModules( array( 'mediawiki.legacy.edit', 'mediawiki.legacy.upload', 'mediawiki.legacy.wikibits', 'mediawiki.legacy.ajax' ) );~~
	960	+ $wgOut->addModules( array( 'mediawiki.action.edit', 'mediawiki.legacy.upload', 'mediawiki.legacy.wikibits', 'mediawiki.legacy.ajax' ) );
961	961	$body_scripts = $wgOut->getHeadScripts( $sk );
962	962	} else {
963	963	global $wgJsMimeType, $wgStylePath, $wgStyleVersion;

Revision	Commit summary	Author	Date
r86603	Move edit.js stuff to mediawiki.action.edit.js, and remove wikibits dependenc...	diebuche	08:19, 21 April 2011

#Comment by F.trott (talk | contribs) 08:36, 11 July 2011

Do we need a version switch here? SF still states compatibility back to 1.15.

#Comment by DieBuche (talk | contribs) 09:01, 11 July 2011

We're already inside a pseudo version switch: if ( method_exists( $wgOut, 'addModules' ) eg. if 1.17 or later

#Comment by F.trott (talk | contribs) 09:30, 11 July 2011

Yes, but it does not cover the switch from mediawiki.legacy.edit to mediawiki.action.edit, right?

#Comment by DieBuche (talk | contribs) 09:38, 11 July 2011

Right. I'll add one later

00:23, 2 March 2012 Krinkle (talk | contribs) changed the tags for r91749 [added: todo]
08:42, 18 January 2012 Siebrand (talk | contribs) changed the tags for r91749 [removed: diebuche-todo added: diebuche]
09:38, 11 July 2011 DieBuche (talk | contribs) changed the tags for r91749 [added: diebuche-todo]