r91724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91723‎ | r91724 | r91725 >
Date:13:50, 8 July 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
Update j.ui.autocomplete which partially broke due to jQuery update in r89866
Modified paths:
  • /trunk/phase3/resources/jquery.ui/jquery.ui.autocomplete.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/jquery.ui.autocomplete.js
@@ -1,5 +1,5 @@
22 /*
3 - * jQuery UI Autocomplete 1.8.11
 3+ * jQuery UI Autocomplete 1.8.14
44 *
55 * Copyright 2011, AUTHORS.txt (http://jqueryui.com/about)
66 * Dual licensed under the MIT or GPL Version 2 licenses.
@@ -490,12 +490,12 @@
491491 this.deactivate();
492492 if (this.hasScroll()) {
493493 var offset = item.offset().top - this.element.offset().top,
494 - scroll = this.element.attr("scrollTop"),
 494+ scroll = this.element.scrollTop(),
495495 elementHeight = this.element.height();
496496 if (offset < 0) {
497 - this.element.attr("scrollTop", scroll + offset);
 497+ this.element.scrollTop( scroll + offset);
498498 } else if (offset >= elementHeight) {
499 - this.element.attr("scrollTop", scroll + offset - elementHeight + item.height());
 499+ this.element.scrollTop( scroll + offset - elementHeight + item.height());
500500 }
501501 }
502502 this.active = item.eq(0)
@@ -601,7 +601,7 @@
602602 },
603603
604604 hasScroll: function() {
605 - return this.element.height() < this.element.attr("scrollHeight");
 605+ return this.element.height() < this.element[ $.fn.prop ? "prop" : "attr" ]("scrollHeight");
606606 },
607607
608608 select: function( event ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89866Upgrade jQuery from 1.4.4 to 1.6.1...krinkle00:25, 11 June 2011

Comments

#Comment by Krinkle (talk | contribs)   20:43, 3 October 2011

Please update jquery.ui as a whole next time. While working on RL2, I ran into some weird undocumented anomalies due to version differences between this and the modules it depends on.

Status & tagging log