r91719 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r91718‎ \| r91719 \| r91720 >
Date:	12:28, 8 July 2011
Author:	freakolowsky
Status:	ok
Tags:
Comment:	* DatabaseOracle.php binds variables, so using $val = 'NULL' breaks certain maint. scripts
Modified paths:	/trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
—	—	@@ -494,6 +494,10 @@
495	495	$val = null;
496	496	}
497	497
	498	+ if ( $val === 'NULL' ) {
	499	+ $val = null;
	500	+ }
	501	+
498	502	if ( $val === null ) {
499	503	if ( $col_info != false && $col_info->isNullable() == 0 && $col_info->defaultValue() != null ) {
500	504	$bind .= 'DEFAULT';

Revision	Commit summary	Author	Date
r92257	MFT r91719, r91618	reedy	17:41, 15 July 2011

21:23, 18 July 2011 Reedy (talk | contribs) changed the tags for r91719 [removed: 1.18]
17:42, 15 July 2011 Reedy (talk | contribs) changed the tags for r91719 [removed: 1.17]
17:27, 15 July 2011 Reedy (talk | contribs) changed the status of r91719 [removed: new added: ok]
21:34, 8 July 2011 Hashar (talk | contribs) changed the tags for r91719 [added: 1.18]
12:29, 8 July 2011 Freakolowsky (talk | contribs) changed the tags for r91719 [added: 1.17]