r91677 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91676‎ | r91677 | r91678 >
Date:20:17, 7 July 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* Fixed comment
* Wrap arround RequestContext::msg() instead of doing that all that stuff once more
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -648,7 +648,7 @@
649649 }
650650
651651 /**
652 - * Shortcut to get the skin being used for this instance
 652+ * Shortcut to get the User executing this instance
653653 *
654654 * @return User
655655 * @since 1.18
@@ -688,15 +688,13 @@
689689 }
690690
691691 /**
692 - * Wrapper around wfMessage that sets the current context. Currently this
693 - * is only the title.
 692+ * Wrapper around wfMessage that sets the current context.
694693 *
695694 * @return Message
696695 * @see wfMessage
697696 */
698697 public function msg( /* $args */ ) {
699 - return call_user_func_array( 'wfMessage',
700 - func_get_args() )->title( $this->getFullTitle() );
 698+ return call_user_func_array( array( $this->getContext(), 'msg' ), func_get_args() );
701699 }
702700
703701 /**

Comments

#Comment by Aaron Schulz (talk | contribs)   05:43, 9 July 2011

What about the title( $this->getFullTitle() ) bit?

#Comment by IAlex (talk | contribs)   07:20, 9 July 2011

This is done in RequestContext::msg() since r91657.

#Comment by Aaron Schulz (talk | contribs)   17:39, 11 July 2011

Ah, my SVN copy was outdated ;)

Status & tagging log