r91564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91563‎ | r91564 | r91565 >
Date:17:03, 6 July 2011
Author:reedy
Status:deferred
Tags:
Comment:
GROUP BY is useful here also
Modified paths:
  • /trunk/extensions/MetricsReporting/metrics/ComScoreUniqueVisitorMetric.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/metrics/ComScoreUniqueVisitorMetric.php
@@ -13,7 +13,7 @@
1414 return array(
1515 'table' => array( 'comscore', 'comscore_regions' ),
1616 'conds' => array(),
17 - 'options' => array( 'GROUP BY' => 'date', 'ORDER BY' => 'date, project_code, region_code' ),
 17+ 'options' => array( 'GROUP BY' => 'comscore.region_code, date', 'ORDER BY' => 'comscore.region_code, date' ),
1818 'join_conds' => array( 'comscore_regions' => array( 'LEFT JOIN', 'comscore.region_code = comscore_regions.region_code' )
1919 ),
2020 );

Status & tagging log