r91563 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91562‎ | r91563 | r91564 >
Date:16:56, 6 July 2011
Author:demon
Status:ok
Tags:
Comment:
Followup r91270: didn't need to be so paranoid about $_SESSION, and actually was causing more issues than it solved.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/api/ApiTestCase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/api/ApiTestCase.php
@@ -40,7 +40,6 @@
4141 if ( is_null( $session ) ) {
4242 $session = array();
4343 }
44 - $_SESSION = $session; // paranoia
4544
4645 $request = new FauxRequest( $params, true, $session );
4746 $module = new ApiMain( $request, true );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91270Merge ApiTestSetup into ApiTestCase and update all subclasses. The amount of ...demon16:34, 1 July 2011

Status & tagging log