r91549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91548‎ | r91549 | r91550 >
Date:12:51, 6 July 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as ok
Modified paths:
  • /trunk/extensions/CodeReview/modules/ext.codereview.styles.css (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.styles.css
——@@ -76,15 +76,6 @@
7777 color: #ff0 !important;
7878 }
7979
80 -.mw-codereview-status-resolved,
81 -.mw-codereview-status-resolved td {
82 - background: #c0ffc0 !important;
83 -}
84 -.mw-codereview-status-resolved:hover,
85 -.mw-codereview-status-resolved:hover td {
86 - background: #a0dfa0 !important;
87 -}
88 -
8980 .mw-codereview-status-reverted,
9081 .mw-codereview-status-reverted td {
9182 background: #ddd !important;

Follow-up revisions

RevisionCommit summaryAuthorDate
r92236Revert r91549 per CRdiebuche10:10, 15 July 2011

Comments

#Comment by 😂 (talk | contribs)   12:54, 6 July 2011

Um, it's supposed to stand out. Please revert.

#Comment by DieBuche (talk | contribs)   13:31, 6 July 2011

Why? Both OK and Resolved are revisions that don't need additional care.

#Comment by 😂 (talk | contribs)   13:39, 6 July 2011

They may not need additional care, but they're different states. Now that I look, we should probably put a different color for deferred/old as well.

#Comment by DieBuche (talk | contribs)   15:46, 6 July 2011

In a lot of color coding green is good, red is bad and hues between (orange/yellow) are in the middle. A similar system is used here. Fixme is obviously not "good", thus red. New is neither, thus yellow. Ok is good, why isn't it green?

#Comment by 😂 (talk | contribs)   16:14, 6 July 2011

Because we wanted different colors for different statuses, having ok/resolved as the same color is a bad idea.

#Comment by Hashar (talk | contribs)   08:30, 9 July 2011

We need the green status. When merging branches, it let us know instantly that the revision might cause trouble and require a followup.

Status & tagging log