r91504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91503‎ | r91504 | r91505 >
Date:23:31, 5 July 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
Partial backport of r80572 per bug 29726: failure in map.exists in WebKit browsers for multiple keys or if a global 'keys' object exists
Modified paths:
  • /branches/REL1_17/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
@@ -134,7 +134,7 @@
135135 * @return boolean Existence of key(s)
136136 */
137137 Map.prototype.exists = function( selection ) {
138 - if ( typeof keys === 'object' ) {
 138+ if ( typeof selection === 'object' ) {
139139 for ( var s = 0; s < selection.length; s++ ) {
140140 if ( !( selection[s] in this.values ) ) {
141141 return false;

Follow-up revisions

RevisionCommit summaryAuthorDate
r91505Partial backport of r80572 per bug 29726: failure in map.exists in WebKit bro...brion23:34, 5 July 2011
r91523Release notes for r90599 and r91504tstarling03:51, 6 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80572Fix bug in mw.Map + fix bug 26801 + wrapper mediawiki.special.upload.js...krinkle16:26, 19 January 2011

Comments

#Comment by Krinkle (talk | contribs)   23:34, 5 July 2011

Yay!

#Comment by Tim Starling (talk | contribs)   03:29, 6 July 2011

Missing release notes.

Status & tagging log