r91466 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91465‎ | r91466 | r91467 >
Date:17:48, 5 July 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
adjusting width of ArticleFeedback-tooltip container.

- Previously much wider than the actual 5-star-rating-container, which was done as a middle way to have tooltips on one line, but due to the last rating-box not having any space to the right this in-between solution looked inconsistent.
However when making it as wide as the 5-star-rating-container (11em) some tooltips will wrap three lines: http://i.imgur.com/HHbGW.png

For now made the width equal to that 11em + 1em = 12em where 1em is the margin between the boxes so it's still wider and won't cause tooltips to span 3 lines, and still not underneath other rating boxes either.

This solution is better than what it was but not ideal and especially when i18n comes in, it's simply unacceptable. This will probably be a moot point when the widget is redesigned to take all the recent modifications into account.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -227,7 +227,7 @@
228228
229229 .articleFeedback-rating-tooltip {
230230 float: left;
231 - width: 170px;
 231+ width: 12em;
232232 margin-left: 12px;
233233 color: #999999;
234234 font-size: 0.9em;

Comments

#Comment by Krinkle (talk | contribs)   17:50, 5 July 2011
#Comment by NeilK (talk | contribs)   21:22, 6 July 2011

seems like a dubious solution (enclosing items of fixed pixel width with ems?) but Krinkle is aware of the issue so marking it okay for deploy

Status & tagging log