r91464 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91463‎ | r91464 | r91465 >
Date:16:52, 5 July 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Bugfix: Localization wasn't loaded LQT-enabled (inexisting) User_talk-pages. Caused the entire editor to be filled with <foobar>. This fixes it.
Modified paths:
  • /trunk/extensions/WikiEditor/WikiEditor.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.php
——@@ -178,7 +178,10 @@
179179 'jquery.wikiEditor.toolbar' => $wikiEditorTpl + array(
180180 'scripts' => 'jquery.wikiEditor.toolbar.js',
181181 'styles' => 'jquery.wikiEditor.toolbar.css',
182 - 'dependencies' => 'jquery.wikiEditor',
 182+ 'dependencies' => array(
 183+ 'jquery.wikiEditor',
 184+ 'jquery.wikiEditor.toolbar.i18n',
 185+ ),
183186 ),
184187 'jquery.wikiEditor.toolbar.config' => $wikiEditorTpl + array(
185188 'scripts' => 'jquery.wikiEditor.toolbar.config.js',

Comments

#Comment by Krinkle (talk | contribs)   16:58, 5 July 2011

To give more context on the issue:

  • MediaWiki 1.19
  • LiquidThreads installed and enabled on all talk pages
  • WikiEditor installed
  • All from trunk

When visiting User_talk:Foobar (inexistant as wiki page, but LiquidThreads is loaded), the editor didn't have any messages loaded. When checking through the console mw.loader.getState('jquery.wikiEditor.toolbar.i18n') returned "registered" instead of "ready".

Status & tagging log