r91377 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91376‎ | r91377 | r91378 >
Date:17:56, 3 July 2011
Author:robin
Status:resolved (Comments)
Tags:
Comment:
Changing back to $wgUser in SpecialImport.php. Importing pages returned "call to undefined method ImportReporter::getSkin()" due to r91246.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialImport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialImport.php
——@@ -350,7 +350,7 @@
351351 $args = func_get_args();
352352 call_user_func_array( $this->mOriginalPageOutCallback, $args );
353353
354 - $skin = $this->getSkin();
 354+ $skin = $wgUser->getSkin();
355355
356356 $this->mPageCount++;
357357

Follow-up revisions

RevisionCommit summaryAuthorDate
r91383Use Linker::linkKnown per Siebrand on r91377.robin20:37, 3 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91246Change usages of $wgUser->getSkin() in special pages to use $this->getSkin()...reedy02:25, 1 July 2011

Comments

#Comment by Siebrand (talk | contribs)   19:17, 3 July 2011

No need to use "$skin = $wgUser->getSkin();" here. You can use the static "Linker::linkKnown( $title )" instead of "$skin->linkKnown( $title )" on line 361.

#Comment by SPQRobin (talk | contribs)   20:39, 3 July 2011

Done in r91383.

Status & tagging log