r91326 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91325‎ | r91326 | r91327 >
Date:23:29, 1 July 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
A style fix for old skins
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css
——@@ -210,6 +210,10 @@
211211 width: 300px;
212212 }
213213
 214+/*#mw-wikilove-dialog*/ #mw-wikilove-add-details #mw-wikilove-message {
 215+ width: 100%; /* some old skins don't include this by default */
 216+}
 217+
214218 /*#mw-wikilove-dialog #mw-wikilove-add-details*/ #mw-wikilove-subtype-description {
215219 margin: 5px 85px 8px 15px;
216220 font-size: 1.0em;

Comments

#Comment by Krinkle (talk | contribs)   19:17, 5 July 2011

Which style, that is by default in some skins, is this covering for ?

#Comment by Kaldari (talk | contribs)   19:37, 5 July 2011

Monobook and Vector (and maybe others) include the style: 

textarea { width: 100%; }

No idea why, but they do.

#Comment by Krinkle (talk | contribs)   19:42, 5 July 2011

The desired behaviour is for the textarea to be as wide as it can be in the parent element. Should indeed not depend on Skin-specific styles.

Alrighty, marking ok.

Status & tagging log