r91293 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91292‎ | r91293 | r91294 >
Date:21:05, 1 July 2011
Author:robin
Status:ok
Tags:
Comment:
Better RTL interface support for CodeReview (bug 29658): paths and code diff should be LTR
Modified paths:
  • /trunk/extensions/CodeReview/modules/ext.codereview.styles.css (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.styles.css
@@ -121,6 +121,9 @@
122122 }
123123
124124 /* Diffs */
 125+.mw-codereview-diff {
 126+ /* @noflip */direction: ltr; /* Source code is always LTR */
 127+}
125128 .mw-codereview-diff ins {
126129 text-decoration: none;
127130 color: green;
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -226,7 +226,8 @@
227227 $ret = "<fieldset><legend>" . wfMsgHtml( 'code-pathsearch-legend' ) . "</legend>" .
228228 '<table width="100%"><tr><td>' .
229229 Xml::openElement( 'form', array( 'action' => $wgScript, 'method' => 'get' ) ) .
230 - Xml::inputlabel( wfMsg( "code-pathsearch-path" ), 'path', 'path', 55, $this->getPathsAsString() ) .
 230+ Xml::inputlabel( wfMsg( "code-pathsearch-path" ), 'path', 'path', 55,
 231+ $this->getPathsAsString(), array( 'dir' => 'ltr' ) ) .
231232 '&#160;' . Xml::submitButton( wfMsg( 'allpagessubmit' ) ) .
232233 $pager->getHiddenFields( array( 'path' ) ) .
233234 Xml::closeElement( 'form' ) .
@@ -434,7 +435,7 @@
435436 $options['status'] = $this->mView->mStatus;
436437 }
437438
438 - return Xml::openElement( 'div', array( 'title' => (string)$value ) ) .
 439+ return Xml::openElement( 'div', array( 'title' => (string)$value, 'dir' => 'ltr' ) ) .
439440 $this->mView->skin->link(
440441 SpecialPage::getTitleFor( 'Code', $title ),
441442 $wgLang->truncate( (string)$value, 50 ),
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -109,7 +109,7 @@
110110 $paths .= $this->formatPathLine( $row->cp_path, $row->cp_action );
111111 }
112112 if ( $paths ) {
113 - $paths = "<div class='mw-codereview-paths'><ul>\n$paths</ul></div>\n";
 113+ $paths = "<div class='mw-codereview-paths' dir='ltr'><ul>\n$paths</ul></div>\n";
114114 }
115115 $comments = $this->formatComments();
116116 $commentsLink = "";
@@ -216,7 +216,7 @@
217217 if ( $viewvc ) {
218218 $url = htmlspecialchars( "$viewvc/?view=rev&revision=$rev" );
219219 $viewvcTxt = wfMsgHtml( 'code-rev-rev-viewvc' );
220 - $revText .= " (<a href=\"$url\" title=\"revision $rev\">$viewvcTxt</a>)";
 220+ $revText .= " (<a href=\"$url\" title=\"revision $rev\">$viewvcTxt</a>)".$wgLang->getDirMark();
221221 }
222222 $links[] = $revText;
223223

Follow-up revisions

RevisionCommit summaryAuthorDate
r91519(follow-up r91518; bug 29658 et al.) Improving RTL support for several extens...robin02:44, 6 July 2011
r91541Follow-up r91293, r91519: use wfUILang() for better backwards compatibilityrobin09:17, 6 July 2011

Status & tagging log