r91221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91220‎ | r91221 | r91222 >
Date:21:13, 30 June 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
r91207: Make one qunit test var local. Thanks Krinkle
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -352,7 +352,7 @@
353353 }
354354 );
355355
356 -ascendingNameLegacy = ascendingName.slice(0);
 356+var ascendingNameLegacy = ascendingName.slice(0);
357357 ascendingNameLegacy[4] = ascendingNameLegacy[5];
358358 ascendingNameLegacy.pop();
359359

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91207r86088: Adding legacy support for .sortbottom & a test for it per CRdiebuche19:40, 30 June 2011

Comments

#Comment by Hashar (talk | contribs)   15:07, 18 July 2011

QUnit tests are not going to be shipped with 1.18. Removing tag.

Status & tagging log