r91168 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91167‎ | r91168 | r91169 >
Date:13:56, 30 June 2011
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
And I forgot to commit this file in r91074
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2577,10 +2577,8 @@
25782578 * Resets all of the given user's page-change notification timestamps.
25792579 * If e-notif e-mails are on, they will receive notification mails on
25802580 * the next change of any watched page.
2581 - *
2582 - * @param $currentUser Int User ID
25832581 */
2584 - function clearAllNotifications( $currentUser ) {
 2582+ function clearAllNotifications() {
25852583 global $wgUseEnotif, $wgShowUpdatedMarker;
25862584 if ( !$wgUseEnotif && !$wgShowUpdatedMarker ) {
25872585 $this->setNewtalk( false );
@@ -2592,7 +2590,7 @@
25932591 array( /* SET */
25942592 'wl_notificationtimestamp' => null
25952593 ), array( /* WHERE */
2596 - 'wl_user' => $currentUser
 2594+ 'wl_user' => $this->getId()
25972595 ), __METHOD__
25982596 );
25992597 # We also need to clear here the "you have new message" notification for the own user_talk page

Follow-up revisions

RevisionCommit summaryAuthorDate
r91241Followup r91168, fix last usage of $currentUser which was undefinedreedy01:30, 1 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91074* Modified some methods of SpecialWatchlist to be non-static so that they can...ialex15:16, 29 June 2011

Comments

#Comment by Reedy (talk | contribs)   01:30, 1 July 2011

You're leaving a u

Status & tagging log