r91163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91162‎ | r91163 | r91164 >
Date:09:10, 30 June 2011
Author:catrope
Status:ok
Tags:
Comment:
Fixes for r91065 per CR: drop stray begin() call and use RUN_MAINTENANCE_IF_MAIN
Modified paths:
  • /trunk/extensions/Vector/switchExperimentPrefs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/switchExperimentPrefs.php
@@ -23,7 +23,6 @@
2424 $total = 0;
2525 $lastUserID = 0;
2626 while ( true ) {
27 - $dbw->begin();
2827 $res = $dbw->select( 'user_properties', array( 'up_user' ),
2928 array( 'up_property' => 'vector-noexperiments', "up_user > $lastUserID" ),
3029 __METHOD__,
@@ -59,6 +58,6 @@
6059 }
6160
6261 $maintClass = 'SwitchExperimentPrefs';
63 -require_once( DO_MAINTENANCE );
 62+require_once( RUN_MAINTENANCE_IF_MAIN );
6463
6564

Follow-up revisions

RevisionCommit summaryAuthorDate
r911641.17wmf1: MFT r91163catrope09:11, 30 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91065Vector: Add maintenance script to switch a preference for users with the noex...catrope10:46, 29 June 2011

Status & tagging log