r91153 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r91152‎ \| r91153 \| r91154 >
Date:	01:44, 30 June 2011
Author:	reedy
Status:	ok (Comments)
Tags:
Comment:	* (bug 29531) r89628 breaks img_auth.php Apply Tims strpos -> strrpos fix, confirmed to work by bug reporter
Modified paths:	/trunk/phase3/img_auth.php (modified) (history)

Diff [purge]

Index: trunk/phase3/img_auth.php
—	—	@@ -46,7 +46,7 @@
47	47	$path = $matches['title'];
48	48
49	49	// Check for bug 28235: QUERY_STRING overriding the correct extension
50		~~-$dotPos = strpos( $path, '.' );~~
	50	+$dotPos = strrpos( $path, '.' );
51	51	$whitelist = array();
52	52	if ( $dotPos !== false ) {
53	53	$whitelist[] = substr( $path, $dotPos + 1 );

Follow-up revisions

Revision	Commit summary	Author	Date
r91440	* Merged r89628 from 1.17: bug 28840 IE URL extension fixes....	tstarling	06:35, 5 July 2011
r91531	MFT r91153 plus release notes: img_auth.php fix	tstarling	07:31, 6 July 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r89628	Merge r89627 from 1.18, equivalent to trunk r89558, r89397, etc.: bug 28840 I...	tstarling	07:00, 7 June 2011

Comments

#Comment by Tim Starling (talk | contribs) 03:33, 6 July 2011

Should have had an entry in RELEASE-NOTES-1.18.

#Comment by Tim Starling (talk | contribs) 03:37, 6 July 2011

Never mind.

Status & tagging log

21:23, 18 July 2011 Reedy (talk | contribs) changed the tags for r91153 [removed: 1.18]
07:40, 6 July 2011 Tim Starling (talk | contribs) changed the tags for r91153 [removed: 1.17]
03:33, 6 July 2011 Tim Starling (talk | contribs) changed the status of r91153 [removed: new added: ok]
01:45, 30 June 2011 Reedy (talk | contribs) changed the tags for r91153 [added: 1.17,1.18]