r91088 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r91087‎ \| r91088 \| r91089 >
Date:	18:05, 29 June 2011
Author:	brion
Status:	deferred
Tags:
Comment:	Code review tweaks for MobileFrontend: fix relative paths on stylesheets, use $wgExtensionAssetsPath explicitly for a hardcoded image
Modified paths:	/trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history) /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
—	—	@@ -203,7 +203,7 @@
204	204	vertical-align: middle; }
205	205	#searchbox #goButton {
206	206	border: 0;
207		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	207	+ background: url(images/s.gif) no-repeat top left;
208	208	height: 25px;
209	209	width: 27px; }
210	210	#searchbox #searchField {
—	—	@@ -217,7 +217,7 @@
218	218	#nav form, #nav button {
219	219	display: inline-block; }
220	220	#nav button {
221		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	221	+ background: url(images/buttonbg.gif) no-repeat center;
222	222	border: 0;
223	223	height: 23px;
224	224	width: 83px; }
—	—	@@ -225,7 +225,7 @@
226	226	#disableButtons {
227	227	text-align: center; }
228	228	#disableButtons button {
229		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	229	+ background: url(images/buttonbg.gif) no-repeat center;
230	230	border: 0;
231	231	height: 23px;
232	232	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
—	—	@@ -288,7 +288,7 @@
289	289	vertical-align: middle; }
290	290	#searchbox #goButton {
291	291	border: 0;
292		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	292	+ background: url(images/s.gif) no-repeat top left;
293	293	height: 25px;
294	294	width: 27px; }
295	295	#searchbox #searchField {
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
—	—	@@ -200,7 +200,7 @@
201	201	vertical-align: middle; }
202	202	#searchbox #goButton {
203	203	border: 0;
204		~~- background: url(/extensions/MobileFrontend/images/s.gif) no-repeat top left;~~
	204	+ background: url(images/s.gif) no-repeat top left;
205	205	height: 25px;
206	206	width: 27px; }
207	207	#searchbox #searchField {
—	—	@@ -214,7 +214,7 @@
215	215	#nav form, #nav button {
216	216	display: inline-block; }
217	217	#nav button {
218		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	218	+ background: url(images/buttonbg.gif) no-repeat center;
219	219	border: 0;
220	220	height: 23px;
221	221	width: 83px; }
—	—	@@ -222,7 +222,7 @@
223	223	#disableButtons {
224	224	text-align: center; }
225	225	#disableButtons button {
226		~~- background: url(/extensions/MobileFrontend/images/buttonbg.gif) no-repeat center;~~
	226	+ background: url(images/buttonbg.gif) no-repeat center;
227	227	border: 0;
228	228	height: 23px;
229	229	width: 83px; }
Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
—	—	@@ -1,4 +1,6 @@
2	2	<?php
	3	+global $wgExtensionAssetsPath;
	4	+
3	5	$searchField = (!empty($_GET['search'])) ? $_GET['search'] : '';
4	6
5	7	$mainPageUrl = self::$mainPageUrl;
—	—	@@ -7,7 +9,7 @@
8	10	$searchWebkitHtml = <<<EOD
9	11	<div id='header'>
10	12	<div id='searchbox'>
11		~~- <img alt='W logo' id='logo' src='/extensions/MobileFrontend/images/w.gif' />~~
	13	+ <img alt='W logo' id='logo' src='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/images/w.gif' />
12	14	<form action='/index.php' class='search_bar' method='get'>
13	15	<input type="hidden" value="Special:Search" name="title" />
14	16	<input type="hidden" value="Search" name="fulltext" />

Status & tagging log

00:20, 14 September 2011 Meno25 (talk | contribs) changed the status of r91088 [removed: old added: deferred]
20:52, 1 August 2011 Reedy (talk | contribs) changed the status of r91088 [removed: new added: old]