r91082 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91081‎ | r91082 | r91083 >
Date:17:20, 29 June 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Add 'api' type to extension types for special version
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -339,7 +339,7 @@
340340 'red-link-title',
341341 'sort-descending',
342342 'sort-ascending',
343 -
 343+
344344 ),
345345 'nstab' => array(
346346 'nstab-main',
@@ -1009,7 +1009,7 @@
10101010 'prefs-help-email',
10111011 'prefs-help-email-others',
10121012 'prefs-help-email-required',
1013 -
 1013+
10141014 'prefs-info',
10151015 'prefs-i18n',
10161016 'prefs-signature',
@@ -3341,6 +3341,7 @@
33423342 'version-variables',
33433343 'version-antispam',
33443344 'version-skins',
 3345+ 'version-api',
33453346 'version-other',
33463347 'version-mediahandlers',
33473348 'version-hooks',
Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -230,6 +230,7 @@
231231 'media' => wfMsg( 'version-mediahandlers' ),
232232 'antispam' => wfMsg( 'version-antispam' ),
233233 'skin' => wfMsg( 'version-skins' ),
 234+ 'api' => wfMsg( 'version-api' ),
234235 'other' => wfMsg( 'version-other' ),
235236 );
236237
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4471,6 +4471,7 @@
44724472 'version-variables' => 'Variables',
44734473 'version-antispam' => 'Spam prevention',
44744474 'version-skins' => 'Skins',
 4475+'version-api' => 'Api',
44754476 'version-other' => 'Other',
44764477 'version-mediahandlers' => 'Media handlers',
44774478 'version-hooks' => 'Hooks',

Follow-up revisions

RevisionCommit summaryAuthorDate
r91140Followup r91082, capitalise API, mark as optionalreedy23:18, 29 June 2011

Comments

#Comment by Siebrand (talk | contribs)   18:43, 29 June 2011

API acronym should be in capitals. Should probably also an optional message.

Status & tagging log