r90978 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90977‎ | r90978 | r90979 >
Date:16:34, 28 June 2011
Author:ankitgarg833
Status:deferred (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/extensions/PageSchemas/specials/GeneratePages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PageSchemas/specials/GeneratePages.php
@@ -45,12 +45,12 @@
4646 if( Title::newFromId($page_id_cat)->getNamespace() == NS_CATEGORY){
4747 $cat_text = Title::newFromId($page_id_cat)->getText();
4848 $generatePagesPage = SpecialPage::getTitleFor( 'GeneratePages' );
49 - $url = $generatePagesPage ->getFullURL() . '/' . $cat_text;
50 - $text .= '<a href='.$generatePagesPage.'</a> <br />';
 49+ $url = $generatePagesPage ->getFullURL() . '/' . $cat_text;
 50+ $text .= '<a href='.$url.'>'.$cat_text.' </a> <br /> ';
5151 }
5252 }
5353 }
54 - $dbr->freeResult( $res );
 54+ $dbr->freeResult( $res );
5555 $wgOut->addHTML( $text );
5656 }else {
5757 //this is when Special:GeneratePages/Category is accessed first time

Comments

#Comment by Reedy (talk | contribs)   16:35, 28 June 2011

Can you please start using commit summaries?

#Comment by 😂 (talk | contribs)   17:48, 28 June 2011

I gave up asking. And Yaron said he's not using CR for this GSoC project anyway, so I wouldn't lose sleep over it.

Status & tagging log