r90972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90971‎ | r90972 | r90973 >
Date:15:47, 28 June 2011
Author:santhosh
Status:resolved (Comments)
Tags:
Comment:
FIX : Bug 29609 - The TT icon overlaps with the "select font" link when wgBetterDirectionality is enabled.
Modified paths:
  • /trunk/extensions/WebFonts/css/webfonts.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/css/webfonts.css
@@ -1,3 +1,8 @@
 2+li#pt-webfont{
 3+ background: url(images/font-icon.png) no-repeat scroll left top transparent;
 4+ padding-left: 15px !important;
 5+}
 6+
27 div#webfonts-menu{
38 margin: 0;
49 padding:0;
@@ -2,2 +7,3 @@
38 font-size: 100%;
 9+ z-index: 99999
410 }
@@ -8,7 +14,6 @@
915 margin: 0;
1016 padding:5px;
1117 font-size: 100%;
12 - z-index: 99999;
1318 }
1419
1520
@@ -34,16 +39,19 @@
3540 div.webfontMenuFocus {
3641 background-position: -22px 60%;
3742 }
 43+
3844 /* @noflip */
39 -body.rtl div.webfontMenu {
 45+body.rtl div.webfontMenu ul li {
4046 direction: rtl;
4147 }
 48+
4249 div.webfontMenu div.menu {
4350 position: relative;
4451 display: none;
4552 clear: both;
4653 text-align: left;
4754 }
 55+
4856 /* OVERRIDDEN BY COMPLIANT BROWSERS */
4957 /* @noflip */
5058 body.rtl div.webfontMenu div.menu {
@@ -115,9 +123,6 @@
116124 }
117125 div.webfontMenu a {
118126 display: block;
119 - padding-left:20px;
120 - background-image: url(images/font-icon.png);
121 - background-position: 0px 60%;
122 - background-repeat: no-repeat;
123 -
 127+ padding-left:5px;
 128+ padding-right:5px;
124129 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r91077Fixed the z-index of webfonts menu, broken in r90972.santhosh15:59, 29 June 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   17:34, 28 June 2011

This breaks the z-index, leaving the menu appearing undernearth the search box:

Broken z-index WebFonts 90972.png

The WebFonts menu item probably shouldn't be appearing all the way on the left like this either; in LTR it sits at the start of the personal menu items, not the end.

#Comment by SPQRobin (talk | contribs)   01:53, 15 August 2011

Marking as new, as it was fixed in r91077.

Status & tagging log